Open
Conversation
mahonin-ms
commented
Aug 20, 2025
- Подправил конфигурацию сборщика под себя: у меня AndroidStudio - 2022.3.1 и jdk - 21
- Реализация функций fizzbuzz и sumOfTwo
added 2 commits
August 20, 2025 23:07
…22.3.1 и jdk - 21 - Реализация функций fizzbuzz и sumOfTwo
motorro
reviewed
Aug 24, 2025
| isDivisionBy3 = currentValue % 3 == 0 | ||
| isDivisionBy5 = currentValue % 5 == 0 | ||
|
|
||
| strings += if(isDivisionBy3 && isDivisionBy5 || currentValue == 0){ |
Collaborator
There was a problem hiding this comment.
@mahonin-ms , обратите внимание на то, как работает оператор += - в него можно зайти по Ctrl+Click. Поскольку длина массива в JVM неизменна, на каждый += создается новый массив с копией предыдущего. Я бы предложил сразу создавать массив нужной длины, а потом менять его элементы. Или можно воспользоваться конструктором массива и вообще за один проход заполнить его данными:
fun fizzbuzz(n: Int): Array<String> = Array(n) { i ->
when {
i == 0 || (i % 3 == 0 && i % 5 == 0) -> "FizzBuzz"
i % 3 == 0 -> "Fizz"
i % 5 == 0 -> "Buzz"
else -> i.toString()
}
}
Author
There was a problem hiding this comment.
Спасибо за подсказку) Выбрал второй вариант через конструктор Array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.